[postgis-devel] Plan release PostGIS 3.4.0 this weekend

[Greg Troxel]

Sebastiaan Couwenberg <sebastic at xs4all.nl> writes:

> Manpages are installed on Linux:

Can somebody point me to how they are installed?

pkgsrc is running configure:

  $ ./configure --enable-rpath --datadir=/usr/pkg/share/postgresql/contrib --with-address-standardizer -with-xsldir=/usr/pkg/share/xsl/docbook --x-includes=/usr/X11R7/include --x-libraries=/usr/X11R7/lib --prefix=/usr/pkg --build=x86_64--netbsd --host=x86_64--netbsd --mandir=/usr/pkg/man --enable-option-checking=yes

and config.status has

  S["PGSQL_MANDIR"]="/usr/pkg/man"                                                                                                                    
  S["mandir"]="/usr/pkg/man"                                                                                                                          

Looking at the build log (which is deep in "make install", and which
seems to install everything else):

  ---- Making install in doc
  gmake[2]: Entering directory '/tmp/work/databases/postgresql-postgis2/work/postgis-3.4.0rc2/doc'
  /tmp/work/databases/postgresql-postgis2/work/.tools/bin/gmake -f Makefile.comments install
  gmake[3]: Entering directory '/tmp/work/databases/postgresql-postgis2/work/postgis-3.4.0rc2/doc'
  mkdir -p '/tmp/work/databases/postgresql-postgis2/work/.destdir/usr/pkg/share/postgresql/contrib/postgis-3.4'
  /usr/bin/install -c -m 644  postgis_comments.sql raster_comments.sql topology_comments.sql sfcgal_comments.sql '/tmp/work/databases/postgresql-post\
  gis2/work/.destdir/usr/pkg/share/postgresql/contrib/postgis-3.4/'
  gmake[3]: Leaving directory '/tmp/work/databases/postgresql-postgis2/work/postgis-3.4.0rc2/doc'
  gmake[2]: Leaving directory '/tmp/work/databases/postgresql-postgis2/work/postgis-3.4.0rc2/doc'


Reading doc/Makefile.in, on line 551 I see

  install: comments-install

and starting on line 496 I see

  man-install: man/shp2pgsql.1 man/pgsql2shp.1 man/pgtopo_export.1 man/pgtopo_import.1 man/postgis.1 man/postgis_restore.1
          mkdir -p $(DESTDIR)$(mandir)/man1
          for f in $^; do \
                  $(INSTALL_DATA) $$f $(DESTDIR)$(mandir)/man1/`basename $$f`; \
          done

and I don't see how the install target depends on the man-install
target.  README.postgis documents the install procedure as just 'make
install'.

I added man-install as a dependency of the install target, and now I get
man pages in the destdir.

I'm boggled as to how this works for anyone else.  Or maybe the Debian
package worked around this bug long ago by calling man-install in doc
during the install phase?



----------------------------------------
$NetBSD$

Fix upstream bug not installing man pages.
Sent upstream by email 20230812.

--- doc/Makefile.in.orig	2023-08-12 06:12:40.000000000 +0000
+++ doc/Makefile.in
@@ -548,7 +548,7 @@ docs-install: html-install html-assets-i
 docs-uninstall: html-uninstall html-assets-uninstall
 	rm -f $(DESTDIR)$(PGSQL_DOCDIR)/postgis/README.postgis
 
-install: comments-install
+install: comments-install man-install
 
 uninstall: comments-uninstall