[postgis-users] collect(geom) in rc3?

[strk at refractions.net]

On Fri, Mar 04, 2005 at 10:23:14AM -0000, Mark Cave-Ayland wrote:
> 
> > -----Original Message-----
> > From: postgis-users-bounces at postgis.refractions.net 
> > [mailto:postgis-users-bounces at postgis.refractions.net] On 
> > Behalf Of Mark Cave-Ayland
> > Sent: 04 March 2005 09:14
> > To: strk at refractions.net; 'PostGIS Users Discussion'
> > Subject: RE: [postgis-users] collect(geom) in rc3?
> 
> (cut)
> 
> > Yes, I can reproduce the crash by doing a simple 'select 
> > collect(the_geom) from geom_table' under Win32 while the same 
> > query works fine under Linux with RC3. Will try and get a 
> > backtrace from gdb....
> 
> 
> Hi strk,
> 
> Here is the backtrace from the crashing 'select collect(the_geom) from
> geom_table'. Is this your segfault fix in geom_accum()?

Probably. This is the patch taking it to RC3:

--- lwgeom_functions_basic.c    25 Feb 2005 09:31:54 -0000      1.108
+++ lwgeom_functions_basic.c    25 Feb 2005 13:28:36 -0000      1.109
@@ -1778,6 +1778,4 @@
 #endif

-       PG_FREE_IF_COPY(geom, 0);
-
        PG_RETURN_ARRAYTYPE_P(result);

--strk;

> 
> 
> 
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to thread 700.0x238]
> 0x0060623c in pfree (pointer=0x191b9d8) at mcxt.c:583
> 583             (*header->context->methods->free_p) (header->context,
> pointer);
> (gdb) bt
> #0  0x0060623c in pfree (pointer=0x191b9d8) at mcxt.c:583
> #1  0x6082b474 in LWGEOM_accum (fcinfo=0x105eec0)
>     at lwgeom_functions_basic.c:1769
> #2  0x004f437e in advance_transition_function (aggstate=0x1919d38, 
>     peraggstate=0x191b540, pergroupstate=0x191b5c8, newVal=26327512, 
>     isNull=0 '\0') at nodeAgg.c:377
> #3  0x004f44e6 in advance_aggregates (aggstate=0x1919d38,
> pergroup=0x191b5c8)
>     at nodeAgg.c:439
> #4  0x004f4ac7 in agg_retrieve_direct (aggstate=0x1919d38) at nodeAgg.c:778
> #5  0x004ec06b in ExecProcNode (node=0x1919d38) at execProcnode.c:353
> #6  0x004ea88e in ExecutePlan (estate=0x1919c10, planstate=0x1919d38, 
>     operation=CMD_SELECT, numberTuples=0, direction=ForwardScanDirection, 
>     dest=0x18b87c0) at execMain.c:1060
> #7  0x004e9c89 in ExecutorRun (queryDesc=0x1910c30, 
>     direction=ForwardScanDirection, count=0) at execMain.c:226
> #8  0x00572ae6 in PortalRunSelect (portal=0x19115c8, forward=1, 
>     count=2147483647, dest=0x18b87c0) at pquery.c:746
> #9  0x0057280b in PortalRun (portal=0x19115c8, count=2147483647, 
>     dest=0x18b87c0, altdest=0x18b87c0, completionTag=0x105f240 "")
>     at pquery.c:561
> #10 0x0056da93 in exec_simple_query (
>     query_string=0x18b80a8 "select collect(the_geom) from tgr12133lka;")
>     at postgres.c:933
> #11 0x0057144a in PostgresMain (argc=4, argv=0x2241f0, 
>     username=0x224118 "postgres") at postgres.c:3007
> #12 0x00541a79 in BackendRun (port=0x105fc30) at postmaster.c:2816
> #13 0x005428bf in SubPostmasterMain (argc=3, argv=0x222548)
>     at postmaster.c:3214
> #14 0x0050754d in main (argc=3, argv=0x222548) at main.c:278
> (gdb)
> 
> 
> 
> Kind regards,
> 
> Mark.
> 
> ------------------------
> WebBased Ltd
> South West Technology Centre
> Tamar Science Park
> Plymouth
> PL6 8BT 
> 
> T: +44 (0)1752 791021
> F: +44 (0)1752 791023
> W: http://www.webbased.co.uk
>